This repository was archived by the owner on Apr 1, 2020. It is now read-only.
[WIP] Refactor some .less files to styled-components #1915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 21, 2018 23:54
|
Not really the person to review this, but I would say its probably worth splitting the QuickInfo refactor out into a second PR, since a bunch of small PRs are easier for someone to look over than a giant one. |
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
=========================================
+ Coverage 35.17% 35.68% +0.5%
=========================================
Files 262 276 +14
Lines 10347 10663 +316
Branches 1322 1343 +21
=========================================
+ Hits 3640 3805 +165
- Misses 6522 6673 +151
Partials 185 185
Continue to review full report at Codecov.
|
|
Thanks for the feedback! With the CI test now working, I will start cherry-picking the changes into different smaller PRs |
|
Closing this in favor of smaller, more focused PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some existing
.lessfiles tostyled-components. The only.lessfiles that are left are those forQuickInfoandTabs, which are by far the most convoluted cases. I might tackle them in a different PR.