@wheyerstrass great work on the PR just a couple of notes re. the config option I think we have a couple related to the tab so the marker option would be best grouped with those e.g. tab.dirtyMarker.color re. the failing tests we have some test in place for the tabs under ui-tests/Tabs.test.tsx I think the snapshot will need updating using yarn test:unit:react -u

Looking through the travis-ci log it looks like the job has been terminated because this happens in a loop:

[20094:0704/160417.525607:INFO:CONSOLE(1)] "[REDUX - LANGUAGE][ACTION] CURSOR_MOVED", source: file:///home/travis/build/onivim/oni/dist/linux-unpacked/resources/app/lib/browser/bundle.js (1)
[20094:0704/160417.526410:INFO:CONSOLE(1)] "[REDUX - NeovimEditor0][ACTION] SET_WINDOW_CURSOR", source: file:///home/travis/build/onivim/oni/dist/linux-unpacked/resources/app/lib/browser/bundle.js (1)
[20094:0704/160417.527114:INFO:CONSOLE(1)] "[SyntaxHighlighting.notifyViewportChanged] - bufferId: 1 topLineInView: 484 bottomLineInView: 514", source: file:///home/travis/build/onivim/oni/dist/linux-unpacked/resources/app/lib/browser/bundle.js (1)

Is this a test I can reproduce locally ? yarn run test and yarn test:react pass.
Could this be related to my prior merge with onivim/master ?

Codecov Report

Merging #2391 into master will decrease coverage by <.01%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
- Coverage    38.2%   38.19%   -0.01%     
==========================================
  Files         300      300              
  Lines       12518    12522       +4     
  Branches     1647     1649       +2     
==========================================
+ Hits         4782     4783       +1     
- Misses       7481     7484       +3     
  Partials      255      255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b12a4f...dbc884f. Read the comment docs.

@wheyerstrass I've re-run the CI test and they pass (they flake out on occasion, which is known were trying to resolve that) thanks for the PR looks good and for making the changes 👍

Just realised you still had a WIP flag on this lemme know if I jumped the gun and we can revert it and re-open the PR sorry about that should have checked in first

@akin909 I wanted to make the config to dirty-marker component passing more robust, because right now this line:

background-color: ${props => props.userColor || props.theme.foreground}

would fail if userColor === ""
I'd add that and then remove the WIP.

@wheyerstrass I can revert the change and you could re-open a PR with the included change or you could add the new change to the updated master and I'll merge that to go with this?

The latter seems the easiest 👍

add the new change in a new PR sorry should have clarified that

I'll make a new PR

@akin909 Ok it looks like it does work as expected. I don't know why
"" | "a" evals to 0 but
a | "a" evals to "a" if a === ""