chore(server): refactor the error variable in server part #9465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @googs1025, appreciate the refactor. Was there a specific usage reason you were looking to refactor these or just to tidy the codebase? |
|
What I understand is: the error variables can be extracted, for example: errMaxRedirectsExceeded errInsecureProtocol. |
|
@BruceMacD /PTAL |
BruceMacD
reviewed
Mar 28, 2025
BruceMacD
approved these changes
Mar 28, 2025
halfcrazy
pushed a commit
to halfcrazy/ollama
that referenced
this pull request
Jun 19, 2025
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor the error variable in server part