runner: clear cache when shift is not possible #9433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-github
reviewed
Mar 1, 2025
jmorganca
reviewed
Mar 1, 2025
jessegross
reviewed
Mar 3, 2025
BruceMacD
commented
Mar 4, 2025
40faf3c to
68776d9
Compare
jessegross
reviewed
Mar 4, 2025
682ea85 to
9c23f11
Compare
jessegross
reviewed
Mar 14, 2025
Clear KV cache when shift operation is not supported by model. Added KvCacheCanShift() check to handle models that can't perform cache shifts, falling back to full cache clear while preserving logical token history to maintain expected behavior when context window fills up.
9c23f11 to
8ac3b75
Compare
jessegross
approved these changes
Mar 31, 2025
halfcrazy
pushed a commit
to halfcrazy/ollama
that referenced
this pull request
Jun 19, 2025
Clear KV cache when shift operation is not supported by model. Added KvCacheCanShift() check to handle models that can't perform cache shifts, falling back to full cache clear while preserving logical token history to maintain expected behavior when context window fills up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear KV cache when shift operation is not supported by model. Added KvCacheCanShift() check to handle models that can't perform cache shifts, falling back to full cache clear while preserving logical token history to maintain expected behavior when context window fills up.
Fixes: #5975
Fixes: #8074
Fixes: #8571
Fixes: #8599
Fixes: #8602
Fixes: #8614
Fixes: #8924
Fixes: #9010
Fixes: #9047
Fixes: #9064
Fixes: #9105
Fixes: #9171
Fixes: #9248
Fixes: #9410