reduce severity of JSON parsing error log, and skip parsing when the log is empty #4743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4743 +/- ##
==========================================
- Coverage 48.91% 48.89% -0.03%
==========================================
Files 356 356
Lines 29809 29811 +2
==========================================
- Hits 14582 14576 -6
- Misses 14066 14072 +6
- Partials 1161 1163 +2 🚀 New features to boost your workflow:
|
|
Asked our agent to file a separate PR for test coverage of logger.go in #4744 |
jLopezbarb
approved these changes
Jul 29, 2025
ifbyol
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes # https://okteto.atlassian.net/browse/PROD-397
Reduce the severity of JSON parsing error log, and skip parsing when the log is empty
How to validate
Please provide step-by-step instructions to replicate your validation scenario. For bug fixes, detail how to reproduce both the bug and its fix, along with any observations.
okteto buildCLI Quality Reminders 🔧
For both authors and reviewers: