Add comprehensive unit tests for pkg/cmd/build/logger.go #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created 44 test cases covering all 7 functions in logger.go - Achieved 100% code coverage for 6/7 functions (96.6% for deployDisplayer) - Tests cover edge cases including error handling, context cancellation, and missing vertices - Uses testify framework for assertions and mock implementations for dependencies - Includes tests for deployDisplayer, newTrace, trace.update, trace.display, trace.isTransferringContext, trace.hasCommandLogs, and trace.removeCompletedSteps Created together with Okteto AI Agent Fleets.
- Applied gofmt formatting fixes - Fixed spacing and alignment issues - Added missing newline at end of file
- Remove nil check before len() call on slice - len() for nil slices is defined as zero in Go - Fixes DeepSource warning about redundant nil check
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4744 +/- ##
==========================================
+ Coverage 48.91% 49.34% +0.42%
==========================================
Files 356 356
Lines 29809 29809
==========================================
+ Hits 14582 14709 +127
+ Misses 14066 13936 -130
- Partials 1161 1164 +3 🚀 New features to boost your workflow:
|
|
Hi @rberrelleza — appreciate the effort here. I’m closing this PR because the tests don’t catch behavior changes in the actual dependency, and our test style avoids if/else in favor of straightforward assertions for readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive unit tests for all functions declared in , achieving excellent code coverage and ensuring robust testing of the build logging functionality.
Changes
Functions Tested
Testing Approach
Coverage Results
Note
The only uncovered line in is the timeout case (line 70) which would require a 10-minute wait to test, making it impractical for unit testing without significant refactoring.
Created together with Okteto AI Agent Fleets 🤖