remove upx #4709
Merged
remove upx #4709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Lopez <javier@okteto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4709 +/- ##
==========================================
+ Coverage 48.85% 48.87% +0.02%
==========================================
Files 354 354
Lines 29522 29522
==========================================
+ Hits 14424 14430 +6
+ Misses 13952 13948 -4
+ Partials 1146 1144 -2 🚀 New features to boost your workflow:
|
ifbyol
approved these changes
May 5, 2025
Dockerfile
Outdated
| && tar -xf /usr/bin/upx.tar.xz -C /tmp \ | ||
| && cp /tmp/upx-4.2.1-amd64_linux/upx /usr/bin/upx \ | ||
| && chmod +x /usr/bin/upx | ||
|
|
||
| # Stage 2: Compress Okteto utility binaries to reduce final image size |
There was a problem hiding this comment.
Suggested change
| # Stage 2: Compress Okteto utility binaries to reduce final image size | |
| # Stage 2: Prepare binaries to be copied in final stages |
Dockerfile
Outdated
|
|
||
| # Stage 3: Set up Go build environment for Kubernetes tools and Okteto CLI | ||
| FROM golang:${GOLANG_VERSION}-bookworm AS golang-builder | ||
| COPY --from=upx-provider /usr/bin/upx /usr/bin/upx | ||
|
|
||
| # Stage 3.1: Download and compress kustomize (Kubernetes resource customization tool) |
There was a problem hiding this comment.
Suggested change
| # Stage 3.1: Download and compress kustomize (Kubernetes resource customization tool) | |
| # Stage 3.1: Download kustomize (Kubernetes resource customization tool) |
Dockerfile
Outdated
| @@ -66,12 +45,7 @@ RUN curl -sLf --retry 3 -o kustomize.tar.gz \ | |||
| && chmod +x /usr/local/bin/kustomize \ | |||
| && rm kustomize.tar.gz \ | |||
| # Verify binary works before compression | |||
There was a problem hiding this comment.
Suggested change
| # Verify binary works before compression | |
| # Verify binary works |
Dockerfile
Outdated
| && /usr/bin/upx --best --lzma /tmp/kustomize \ | ||
| # Verify compressed binary still works | ||
| && /tmp/kustomize version | ||
| && /usr/local/bin/kustomize version | ||
|
|
||
| # Stage 3.2: Download and compress kubectl (Kubernetes CLI) |
There was a problem hiding this comment.
Suggested change
| # Stage 3.2: Download and compress kubectl (Kubernetes CLI) | |
| # Stage 3.2: Download kubectl (Kubernetes CLI) |
Dockerfile
Outdated
| @@ -82,12 +56,7 @@ RUN curl -sLf --retry 3 -o kubectl \ | |||
| && chmod +x kubectl \ | |||
| && mv kubectl /usr/local/bin/ \ | |||
| # Verify binary works before compression | |||
There was a problem hiding this comment.
Suggested change
| # Verify binary works before compression | |
| # Verify binary works |
Dockerfile
Outdated
| && /usr/bin/upx --best --lzma /tmp/kubectl \ | ||
| # Verify compressed binary still works | ||
| && /usr/local/bin/kubectl version --client=true | ||
| && /usr/local/bin/kubectl version --client=true | ||
|
|
||
| # Stage 3.3: Download and compress Helm (Kubernetes package manager) |
There was a problem hiding this comment.
Suggested change
| # Stage 3.3: Download and compress Helm (Kubernetes package manager) | |
| # Stage 3.3: Download Helm (Kubernetes package manager) |
Dockerfile
Outdated
| @@ -101,12 +70,7 @@ RUN curl -sLf --retry 3 -o helm.tar.gz \ | |||
| && chmod +x /usr/local/bin/helm \ | |||
| && rm -rf helm helm.tar.gz \ | |||
| # Verify binary works before compression | |||
There was a problem hiding this comment.
Suggested change
| # Verify binary works before compression | |
| # Verify binary works |
Dockerfile
Outdated
| && /usr/bin/upx --best --lzma /tmp/helm \ | ||
| # Verify compressed binary still works | ||
| && /tmp/helm version | ||
| && /usr/local/bin/helm version | ||
|
|
||
| # Stage 3.4: Download and compress git (Version control system) |
There was a problem hiding this comment.
Suggested change
| # Stage 3.4: Download and compress git (Version control system) | |
| # Stage 3.4: Download git (Version control system) |
Dockerfile
Outdated
| @@ -176,19 +135,19 @@ FROM busybox:${BUSYBOX_VERSION} | |||
| COPY --link --chmod=755 --from=certs /etc/ssl/certs /etc/ssl/certs | |||
|
|
|||
| # Step 2: Copy compressed Kubernetes tools | |||
There was a problem hiding this comment.
Suggested change
| # Step 2: Copy compressed Kubernetes tools | |
| # Step 2: Copy Kubernetes tools |
Signed-off-by: Javier Lopez <javier@okteto.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 5, 2025
* remove upx Signed-off-by: Javier Lopez <javier@okteto.com> * refactor: update comments for clarity in Dockerfile stages Signed-off-by: Javier Lopez <javier@okteto.com> --------- Signed-off-by: Javier Lopez <javier@okteto.com> (cherry picked from commit a0213b8)
jLopezbarb
added a commit
that referenced
this pull request
May 5, 2025
* remove upx Signed-off-by: Javier Lopez <javier@okteto.com> * refactor: update comments for clarity in Dockerfile stages Signed-off-by: Javier Lopez <javier@okteto.com> --------- Signed-off-by: Javier Lopez <javier@okteto.com> (cherry picked from commit a0213b8) Co-authored-by: Javier López Barba <javier@okteto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove upx so we can have CVEs reports