Skip to content

Conversation

curator
Copy link

@curator curator commented Feb 7, 2025

Fixes #268

monde added a commit that referenced this pull request Feb 10, 2025
@monde monde mentioned this pull request Feb 10, 2025
@monde
Copy link
Collaborator

monde commented Feb 10, 2025

Thanks @curator I'll release today. I have to bring your commit in a PR I create to satisfy our GH security rules.

@monde
Copy link
Collaborator

monde commented Feb 10, 2025

@curator I'm going to rewrite your commits as my own but give you credit. We have signed commits requirements on our merge protections.

image

https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@monde
Copy link
Collaborator

monde commented Feb 10, 2025

@curator actually, it's still your commit, I just added my signature so the SHA of the commit changed, fyi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-s and --aws-session-duration are not respected, but --session-duration is
2 participants