fix calculate inputtext callback utf-8(chinese input) length #3587
Conversation
|
The code you changed doesn’t calculate text length. Please provide a repro of your actual issue and make sure your callback function sets the dirty flag in the callback data buffer. |
|
Hmm
I think we should keep the existing test but add || callback_data.BufDirty to all the 3 tests this way the computation is not done every time.
|
|
Yes, it should be like this: if (callback_data.CursorPos != utf8_cursor_pos || callback_data.BufDirty) { state->Stb.cursor = ImTextCountCharsFromUtf8(callback_data.Buf, callback_data.Buf + callback_data.CursorPos); state->CursorFollow = true; } |
|
I don't think we need add all three checks, but only the first one. |
The Selection fields are also position will would be affected by the same UTF-8<>wchar count transition. Thank you, will merge this soon.
By the way, the https://github.com/ocornut/imgui/wiki/Useful-Widgets page is listing this project: |
…lters the buffer in a way where the byte count is unchanged but the decoded character count changes. (#3587)
|
Merged. |
This PR want fix a bug about InputText callback:
In InputText callback I want translate chinese pinyin 'hao' to '好', before callback 'hao' length is 3,
after callback '好''s utf-8 length is 3 too. So ImTextCountCharsFromUtf8 was ignored, that's not right.
Anyway, ImTextCountCharsFromUtf8 should be called to calculate real length.