Use SDL system cursors in SDL OpengGL3 example #1626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Oliver. |
|
Sure I've just noticed the |
|
I think it's fine. SDL doesn't specify the scope of those system cursor and they don't seem tied to a graphics context. At least for Windows they are OS hardware cursors anyway. |
|
OK, I moved them into the |
ocornut
added a commit
that referenced
this pull request
Feb 16, 2018
…l. SDL: Fixed cursor. (#1626)
ocornut
added a commit
that referenced
this pull request
Feb 16, 2018
…rsor_None so it doesn't underflow array. Fixed harmless uninitialized pointer. (#1626)
|
Merged with minor tweaks, thanks Oliver! |
|
Cheers :) Thanks so much for this great library! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
ImGui::GetMouseCursor()to select the correct SDL system cursor inImGui_ImplSdlGL3_NewFrame.Creates the
SDL_Cursors inImGui_ImplSdlGL3_CreateDeviceObjects, not sure if this is the best/intended structure.