Backends: Vulkan: Fix setting preTransform during SwapChain creation #8222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
pushed a commit
that referenced
this pull request
Dec 11, 2024
…m for platforms not supporting VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR. (#8222)
|
Thank you! This is merged as e487eb9 (i moved the cap query above so we keep filling fields in struct order) |
|
Perfect, Thanks. |
matthew-mccall
pushed a commit
to matthew-mccall/imgui
that referenced
this pull request
Jan 1, 2025
…m for platforms not supporting VK_SURFACE_TRANSFORM_IDENTITY_BIT_KHR. (ocornut#8222)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a platform (under NDA), which doesnt support the default set
preTransform, so this PR is ensure a valid tranformation would be selected.Note: I'm not entirely sure if the check is need vs using
currentTransformdirectly, but this does atleast ensure there is no change in behaviour when there are multiple supported transformations.