Skip to content

Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown #6790

wants to merge 1 commit into from

Conversation

halx99
Copy link
Contributor

@halx99 halx99 commented Sep 6, 2023 •
edited
Loading

Version/Branch of Dear ImGui:

Version: v1.89.8-docking

reproduce demo without this patch:
https://axmolengine.github.io/axmol/wasm/cpp_tests/cpp_tests.html
step:

  1. open 2.ImGui
  2. Goback to main manu page
  3. Scroll mouse whell, will see javascript exception on console

@ocornut ocornut changed the title [Backend][GLFW]: Clear mosewheel callback before shutdown Backends: GLFW: Clear MouseWheel Emscripten callback before shutdown Sep 6, 2023
@halx99 halx99 changed the title Backends: GLFW: Clear MouseWheel Emscripten callback before shutdown Bckends: GLFW: Clear mosewheel callback before shutdown Sep 6, 2023
@ocornut ocornut added web and removed ime labels Sep 6, 2023
ocornut pushed a commit that referenced this pull request Sep 6, 2023
@halx99 @ocornut
Backends: GLFW: Clear emscripten's MouseWheel callback before shutdow…
56a7b8b 
…n. (#6790, #6096, #4019)
@ocornut
Copy link
Owner

ocornut commented Sep 6, 2023

Thank you for this.
Moved the code in right location and pushed as 56a7b8b

@ocornut ocornut closed this Sep 6, 2023
@ocornut ocornut changed the title Bckends: GLFW: Clear mosewheel callback before shutdown Bckends: GLFW: Clear emscripten's mousewheel callback before shutdown Sep 6, 2023
halx99 added a commit to axmolengine/axmol that referenced this pull request Sep 6, 2023
@halx99
ImGui: Clear emscripten's MouseWheel callback before shutdown.
19509ed 
refer: ocornut/imgui#6790
@halx99 halx99 deleted the patch-1 branch September 10, 2023 03:31
Repository owner deleted a comment from TST539996 Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backends web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halx99 @ocornut