Properly honor GLFW_CURSOR_DISABLED #6609
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLFW_CURSOR_DISABLED now causes ImGuiConfigFlags_NoMouse to be set automatically, which disables any mouse interactions with the UI, but still updates the mouse position internally
This is done so we don't interfere with the user setting ImGuiConfigFlags_NoMousewhile the cursor is disabled (This would previously cause automatic clearing, even though the user set NoMouse manually).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things:
By setting an analogous backend flag to
ImGuiConfigFlag_NoMousewhenGLFW_CURSOR_DISABLEDis set, ImGui won't hover items with the virtual cursor, while also providing up-to-date cursor positions (#5625 (comment)).I opted to add a backend flag instead of just using
ImGuiConfigFlag_NoMouseto avoid interfering with the user setting this flag (See also the commit message for da049f3). A version that just usesImGuiConfigFlag_NoMousecan be found at the commit c7013bd though.