Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2022

2 lines of code change.

@ghost
Copy link
Author

ghost commented Aug 28, 2022

It got so annoying to not have it in my dear imgui-based gamescript code editor, I decided to fix it myself and PR the solution 😝

@ocornut
Copy link
Owner

ocornut commented Sep 1, 2022

Thank you, this looks like a great improvement. To be fair I'm surprised we didn't get this in earlier (I myself use this from time to time).

I'll need to review this a little more as InputTextEx() is notoriously complex, give me some time.

@ocornut ocornut removed the bug label Sep 1, 2022
@ghost
Copy link
Author

ghost commented Sep 1, 2022

@ocornut Sure, no problem! Thank you!

@ocornut
Copy link
Owner

ocornut commented Sep 5, 2022

I merged this as b87e58f 95e609a with a small change of logic.
I believe it is easier to read this way (compared to 9a1243a). I hope I didn't make a mistake with the change :)

Thank you!

(Also removed a comment I don't understand anymore. If the thing is meaningful/needed we'll find it soon enough)

@ocornut ocornut closed this Sep 5, 2022
ocornut pushed a commit that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant