Metal: add dispatch synchronization #5447
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @warrenm for feedback as this is all a mystery to me :) |
|
Looks like an improvement to me. We could also use |
ocornut
pushed a commit
that referenced
this pull request
Jul 5, 2022
|
Merged! Thank you Luigi for the PR and Warren for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes to add a
@synchronizedmutex to control access toself.bufferCacheon the Metal implementation file. This avoids a situation where thisNSArrayis mutated by thedispatch_async(...)while being enumerated bydequeueReusableBufferOfLength(...). This scenario happens when the ImGui render loop is offloaded to a different thread after being initialized on a parent thread. As far as I understand, this change won't add overhead while running on a single thread but will avoid eventual crashes if the circumstance described above happens.