Skip to content

bugfix: default scopes for OIDCProvider based providers #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

bugfix: default scopes for OIDCProvider based providers #2229

merged 1 commit into from
Sep 11, 2023

Conversation

tuunit
Copy link
Member

@tuunit tuunit commented Sep 10, 2023 •
edited
Loading

Description

This PR fully fixes the scope issues introduced by moving the oidc default scope logic to the NewOIDCProvider method #2197

Motivation and Context

Default scopes are broken for the keycloak-oidc provider in v7.5.0

How Has This Been Tested?

  1. Tested locally with keycloak-oidc and oidc (dex) providers.
  2. Additional unit tests for scope changes for all OIDCProvider based providers: oidc, gitlab and adfs

Checklist:

  • My change requires a change to the documentation or CHANGELOG.
  • I have updated the documentation/CHANGELOG accordingly.
  • I have created a feature (non-master) branch for my PR.

@tuunit tuunit requested a review from a team as a code owner September 10, 2023 20:03
@tuunit tuunit changed the title bugfix: default scopes for OIDCProvider based providers [WIP] bugfix: default scopes for OIDCProvider based providers Sep 10, 2023
@tuunit tuunit force-pushed the bugfix/default-scopes-for-oidc-based-providers branch from ea8d441 to 7683902 Compare September 10, 2023 20:10
@tuunit tuunit changed the title [WIP] bugfix: default scopes for OIDCProvider based providers bugfix: default scopes for OIDCProvider based providers Sep 10, 2023
@JoelSpeed JoelSpeed added the bug label Sep 11, 2023
@JoelSpeed JoelSpeed merged commit 854401e into oauth2-proxy:master Sep 11, 2023
@tuunit tuunit mentioned this pull request Sep 12, 2023
Closed
@tuunit tuunit added this to the v7.5.1 milestone Sep 13, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Sep 22, 2023
Merged
@tuunit tuunit mentioned this pull request Oct 6, 2023
Closed
@tuunit tuunit deleted the bugfix/default-scopes-for-oidc-based-providers branch December 17, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v7.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tuunit @JoelSpeed