bugfix: move oidc scope logic to oidc provider #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuunit please add |
3 tasks
JoelSpeed
reviewed
Sep 7, 2023
dced5bd to
6f6039c
Compare
|
@JoelSpeed Sorry that I didn't notice this was missed in the release :/ |
|
@tuunit I think it has to be included in the description with something like |
JoelSpeed
approved these changes
Sep 8, 2023
This was referenced Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
The OIDC provider shouldn't be treated as anything specially where as all the other providers have their internal scope logic defined in the specific provider files the scope logic for oidc and in extension the keycloak-oidc provider is located in the providers.go.
To align the OIDC and Keycloak OIDC provider I moved the logic to the oidc.go provider file.
How Has This Been Tested?
Checklist:
Replaces PR: #1989
Fixes:#2222