Add stable API support for RTypedData
#530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce RTYPEDDATA_P, RTYPEDDATA_EMBEDDED_P, RTYPEDDATA_TYPE, and RTYPEDDATA_GET_DATA macros and stable API methods for working with Ruby's RTypedData objects. - Provide Ruby version-specific implementations (2.6–3.4) for type checking, embedded data detection, type retrieval, and data pointer access. - Add comprehensive tests for RTypedData handling in stable_api_test.rs. - Update CI to test against ruby-head. - Extend blocklists and opaque structs for RData/RTypedData.
Update type and constants to use Compiled struct and Ruby API version constants.
Add cfg to skip failing test on Ruby 3.5 and above.
Moves ruby-head to its own job with Ubuntu and stable Rust, removing it from the main Ruby matrix to improve CI reliability.
goyox86
reviewed
May 7, 2025
stanhu
added a commit
to stanhu/rb-sys
that referenced
this pull request
May 8, 2025
AFter upgrading to rb-sys v0.9.113, we found that oxidize-rb#530 doesn't compile on 32-bit platform because the typed_data is a VALUE type, but it was always casted to a 64-bit value. Fix this by casting TYPED_DATA_EMBEDDED as a VALUE. Closes oxidize-rb#534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby 3.5, the struct definition of
RTypedDatawas changed to optimize its size. To support this, this PR addsrtypeddata_p,rtypeddata_embedded_p,rtypeddata_type, andrtypeddata_get_datain StableApiDefinition for Ruby 2.6–3.4.