Make it possible to override RUBY_TARGET #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 798fad1.
Previously if you attempt to run `rb-sys-dock --platform x86_64-linux-gnu` the `RUBY_TARGET` was hard-coded to `x86_64-linux`. Now this can be overriden by the `rb-sys-dock` so that the `--platform` argument can work with `x86_64-linux` or `x86_64-linux-gnu`.
ianks
approved these changes
Jan 30, 2025
|
I seem to be making things worse here: https://github.com/oxidize-rb/rb-sys/actions/runs/13059416829/job/36438458768 I'm not sure why |
stanhu
added a commit
to stanhu/rb-sys
that referenced
this pull request
Jan 30, 2025
This reverts commit 7b03755.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #511 because the CI test expected that
rb-sys-dock --platform x86_64-linux --directory . --buildproduces a gem with a suffix of-x86_64-linux.gem.This change drops the hard-coded
RUBY_TARGETfrom the bash script so the value can be derived from theENVsetting. With this change, this is now possible:rb-sys-dock --platform x86_64-linux --directory . --buildproduces a gem with a filename-x86_64-linux-gnu.gem.rb-sys-dock --platform x86_64-linux-gnu --directory . --buildproduces a gem with a filename-x86_64-linux-gnu.gem.