Skip to content

Various build fixes #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Various build fixes #402

merged 7 commits into from
Sep 26, 2022

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Sep 25, 2022

See each commit for details. I have done this in order to package this project for Gentoo Linux. Many thanks for your efforts, it's working great for me. 😄

This is particularly useful in cross-compile situations, where a wrapper
around pkg-config is sometimes needed.
This is done in a cross-compile-friendly manner with cpp rather than
uname. printf is used rather than echo due to inconsistent handling of
the -e option across different shells.
It has provided one since version 1.5. It erroneously hardcodes the
libdir as "lib" (it may be lib64), but OwnTracks defaulted to "lib"
anyway. I will fix Mosquitto shortly.
ot-record creates it automatically. Other directories are also created
automatically, so we should be consistent here. Note that some package
managers need special handling for empty directories at build time, but
they don't care about directories created at runtime.
As the Linux kernel experiment with this flag has shown, it's just a bad
idea unless you regularly do development work on the project. Different
compilers and compiler versions will emit different warnings, which will
cause headaches for users.
Copy link
Member

@jpmens jpmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

@jpmens jpmens merged commit 0036ad9 into owntracks:master Sep 26, 2022
@jpmens
Copy link
Member

jpmens commented Sep 26, 2022

Merged, thank you!

@chewi chewi deleted the build-fixes branch September 26, 2022 20:51
jpmens added a commit that referenced this pull request Sep 29, 2022
- FIX: Remove accidental eval (#403)
- FIX: Various build fixes (#402)
- FIX: now compiles without MQTT (#401)
- FIX: read OTR_TOPICS from environment (overrides config); can be overriden by argv
- UPD: ocat -v shows compiled-in values, ot-recorder -V runtime ones
- FIX: add "OTR_HTTPPREFIX" (verbatim) to tour url if prefix unconfigured (#399)
- FIX: Duplicate log entries when running as daemon (#398)
- FIX: package build for raspbian
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants