Fix the view lastpos response. #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The locarray json data is transferred to the response object and if it is deleted here results in an empty object being returned to the user and the default view just shows "Imported data is malformed" instead of a map. This restores the vmap functionality. Signed-off-by: Pat Thoyts <pat.thoyts@gmail.com>
|
Merged, thank you! |
|
I think this might re-open one of the memory leaks we closed in #464 Needs investigation. |
|
I'm fairly sure this does not re-introduce a leak. The locarray is attached as the data member of the response object. In the json_response function this object is deleted by json_delete() which iterates over its members and calls delete on each which then deals with the locarray. I gave valgrind a try and there is no difference between making a single call to get the view lastpos and making 20 such calls. |
|
Thank you very much for doing that, Pat -- much appreciated, as I won't have to dig out ye olde valgrinde myself. :-) |
jpmens
added a commit
that referenced
this pull request
Jul 23, 2024
- FIX: add card data to websocket notifications (#450) - FIX: Enable building when WITH_TZ=no to disable timezone information (#473) - FIX: view lastpos response (#471) - FIX: handle out-of-order location notification in last/ (#472) - FIX: drastically reduce memory leakage in views (#464) - FIX: reformat json if it contains newlines/tabs before storing in .rec (#437) - NEW: cached geo records can be auto-expired by setting OTR_CLEAN_AGE (#447) - NEW: option -J prints variables in JSON format, for scripting - NEW: version is printed in -J / -V - FIX: in http mode friends' data must contain a topic; construct it or retrieve from last if available (#451) - FIX: crash on non-string event name in _transition messages (#454) - NEW: Add alt field to GeoJSON points parameters (#456)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The locarray json data is transferred to the response object and if it is deleted here results in an empty object being returned to the user and the default view just shows "Imported data is malformed" instead of a map. This restores the vmap functionality.