Skip to content

Conversation

DSpeichert
Copy link
Member

Pull Request Prelude

  • I have followed [proper The Forgotten Server code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

  • Find PEM header and footer in key.pem instead of assuming it is exactly the entirety of the file.
  • Color startup errors with fmt

See: https://cryptopp.com/wiki/Keys_and_Formats#PEM_Encoded_Keys

@DSpeichert DSpeichert requested a review from ranisalt February 14, 2022 23:15
@ghost ghost merged commit 474b959 into otland:master Feb 17, 2022
@DSpeichert DSpeichert deleted the rsa-loading branch February 17, 2022 02:20
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Feb 23, 2022
DSpeichert pushed a commit that referenced this pull request Mar 27, 2022
#3940 introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue
Codinablack pushed a commit to Codinablack/forgottenserver that referenced this pull request Apr 5, 2022
otland#3940 introduced a colored message
colored messages sometimes fail to process in command prompt/powershell
this code fixes that issue

(cherry picked from commit 73bdc12)
DSpeichert added a commit that referenced this pull request May 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants