Change default value to NULL for conditions #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ CREATE TABLE IF NOT EXISTS `players` ( | |||
| `posx` int NOT NULL DEFAULT '0', | |||
| `posy` int NOT NULL DEFAULT '0', | |||
| `posz` int NOT NULL DEFAULT '0', | |||
| `conditions` blob NOT NULL, | |||
| `conditions` blob DEFAULT NULL, | |||
There was a problem hiding this comment.
This seems like a sane change, but considering there are already projects using that field, for example web AACs as string, it might be reasonable to do DEFAULT ''?
Nevermind. MySQL does not support default values for blob 🙄.
ghost
approved these changes
Nov 23, 2021
|
Hold up! Where the migration is? |
It does not break/change anything, so there is none. |
|
would conflict with upcoming version 12 migrations |
It does change schema, so now you introduce divergence... wouldn't hurt to have a migration for that. |
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Jan 30, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honestly, idk why it's NOT NULL as this is binary, but it only triggers me when I manually add entries thru phpmyadmin and it spits out errors, cause conditions cannot be null.
Default value for this should be null, this should not affect anything in loading and will fix that annoyance.