Skip to content

Use nextUseStaminaTime only on gain experience #3779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Dec 9, 2021
Merged

Use nextUseStaminaTime only on gain experience #3779

1 commit merged into from
Dec 9, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Use nextUseStaminaTime only on gain experience.
  • Add the player to the array only if he gain experience, saving memory (even though little).

@ghost ghost requested review from DSpeichert, nekiro, ranisalt and Znote December 9, 2021 14:07
nekiro
nekiro approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@nekiro nekiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, why not

@ghost ghost merged commit a9b4746 into otland:master Dec 9, 2021
@ghost ghost deleted the stamina-only-on-use branch December 9, 2021 19:24
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Jan 30, 2022
@ramon-bernardo @Znote
Use nextUseStaminaTime only player gain experience (otland#3779)
1802210
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@ramon-bernardo @DSpeichert
Use nextUseStaminaTime only player gain experience (#3779)
a4f53ef
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekiro nekiro nekiro approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@ranisalt ranisalt Awaiting requested review from ranisalt

@Znote Znote Awaiting requested review from Znote

+2 more reviewers

@Erza Erza Erza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramon-bernardo @Erza @nekiro