Skip to content

Send distance effect to spectators on other floors #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 23, 2021
Merged

Send distance effect to spectators on other floors #3723

1 commit merged into from
Oct 23, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Send distance effect to spectators on other floors

@ghost ghost requested review from DSpeichert, nekiro and ranisalt October 11, 2021 21:28
ghost
ghost approved these changes Oct 11, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is confirmed that just like magic effects, distance effects should be also sent to other floors

@ghost ghost merged commit 78c0f3d into otland:master Oct 23, 2021
@ghost ghost deleted the spec-dist-effect branch October 23, 2021 05:01
Znote pushed a commit that referenced this pull request Nov 1, 2021
@ramon-bernardo @Znote
Send distance effect to spectators on other floors (#3723)
515924d
@Znote Znote mentioned this pull request Nov 1, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

@ranisalt ranisalt Awaiting requested review from ranisalt

1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramon-bernardo