Reduce broadcast range for container updates #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Sep 17, 2021
DSpeichert
approved these changes
Sep 17, 2021
|
why are we looping twice though in these methods? Instead of once and execute both methods (sendUpdate, onUpdate) |
I don't know either, but it is like that all over the codebase. Once I read a comment somewhere on this repo about there being a possible race condition if it's not done this way? Might be wrong tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Containers can never be opened if a player is more than 1 SQM away from it, hence we are doing unnecessary work here by sending updates to clients that are too far away from the container
Issues addressed: