Skip to content

Conversation

vonzshik
Copy link
Contributor

Fixes #5993

@vonzshik vonzshik requested a review from roji as a code owner February 20, 2025 10:22
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but see comment about what happens if we get something that isn't X509Certificate2

@vonzshik vonzshik enabled auto-merge (squash) February 21, 2025 09:53
@vonzshik vonzshik merged commit 44a7ab1 into main Feb 21, 2025
12 checks passed
@vonzshik vonzshik deleted the 5993-ssl-stream-always-dispose-RemoteCertificate branch February 21, 2025 09:55
vonzshik added a commit that referenced this pull request Feb 21, 2025
@vonzshik
Copy link
Contributor Author

vonzshik commented Feb 21, 2025

Backported to 9.0.3 via 94d0a14, 8.0.6 via 61f3a2a

vonzshik added a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SslStream RemoteCertificate disposal
2 participants