Add support for postgresql type names with dots #5971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, mind adding a few test cases? Contributes to #5710 |
|
Contributes to #5972 |
Added test case with schema_name."Test.type.name" |
|
I need this fix in Npgsql v8, is it possible? |
Yeah, we'll probably backport it to npgsql 8. BTW could you try to rebase on the latest main? It looks like there is an issue with the CI pipeline. |
|
Huh, for some reason it shows much more changes than it should... |
5b4ebb7 to
d2e7534
Compare
For composite type with dots in name, Postgresql returns name with quotes - scheme."My.type.name", but for npgsql mapping we should use names without quotes - scheme.My.type.name
d2e7534 to
d7159a0
Compare
Fixed, but unfortunately a few more reviewers were added because of this error |
|
OK, I think it's fine to merge this now. |
vonzshik
pushed a commit
that referenced
this pull request
Feb 4, 2025
vonzshik
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem of converting type names with dots, for example the name "public.audit.sessiontype" was parsed incorrectly and had namespace after parse "audit" and name - "sessiontype".
If the schema is not null or empty, then displayname must contain only the type name.