Fix explicit prepare/unprepare after error 0A000 #5869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
commented
Oct 5, 2024
| @@ -61,7 +61,8 @@ internal PreparedStatementManager(NpgsqlConnector connector) | |||
| if (BySql.TryGetValue(sql, out var pStatement)) | |||
| { | |||
| Debug.Assert(pStatement.State != PreparedState.Unprepared); | |||
| if (pStatement.IsExplicit) | |||
| // If statement is invalidated, fall through below where we replace it with another | |||
| if (pStatement.IsExplicit && pStatement.State != PreparedState.Invalidated) | |||
There was a problem hiding this comment.
Strictly speaking, changes in this file aren't required for the fix. But they do allow to just call Prepare again after error 0A000 instead of calling both Unprepare and Prepare together. All in all I'm ok with removing this part (or for example just not backporting this particular change).
roji
approved these changes
Oct 7, 2024
vonzshik
added a commit
that referenced
this pull request
Oct 7, 2024
vonzshik
added a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5864