Skip to content

Fix writing composites with enum #5837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix writing composites with enum #5837

merged 2 commits into from
Oct 13, 2024

Conversation

vonzshik
Copy link
Contributor

Fixes #5835

@vonzshik vonzshik requested a review from roji as a code owner September 13, 2024 10:41
@NinoFloris NinoFloris force-pushed the 5835-fix-composite-with-enum branch from 7057d4f to 9a1b561 Compare September 17, 2024 13:59
@NinoFloris NinoFloris force-pushed the 5835-fix-composite-with-enum branch from 9a1b561 to d57146d Compare September 27, 2024 13:59
@NinoFloris
Copy link
Member

Regarding #5841 which is an improvement to the accuracy of the buffer requirements. We can choose to still take + backport it after this one, for correctness just this PR is enough though.

@vonzshik
Copy link
Contributor Author

Regarding #5841 which is an improvement to the accuracy of the buffer requirements. We can choose to still take + backport it after this one, for correctness just this PR is enough though.

There was also an improvement with allowing enums to be written without buffering but yeah, I'll just do a separate pr containing both of them, and it's not like we have to backport that.

@vonzshik vonzshik merged commit 53b9fa5 into main Oct 13, 2024
15 checks passed
@vonzshik vonzshik deleted the 5835-fix-composite-with-enum branch October 13, 2024 04:11
vonzshik added a commit that referenced this pull request Oct 13, 2024
@vonzshik @NinoFloris
Fix writing composites with enum (#5837)
8a19263 
Fixes #5835

Co-authored-by: Nino Floris <mail@ninofloris.com>
(cherry picked from commit 53b9fa5)
@vonzshik
Copy link
Contributor Author

Backported to 8.0.5 via 8a19263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NinoFloris NinoFloris NinoFloris approved these changes

@roji roji Awaiting requested review from roji roji is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arithmetic overflow executing a query with a composite type parameter that contains an enum
2 participants
@vonzshik @NinoFloris