Skip to content

Add the field (column) name to ReplicationValue #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2024
Merged

Add the field (column) name to ReplicationValue #5719

merged 2 commits into from
Jun 28, 2024

Conversation

Brar
Copy link
Member

@Brar Brar commented May 21, 2024

Closes #5718

@Brar Brar requested review from roji and vonzshik as code owners May 21, 2024 17:40
roji
roji approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense - looks like an oversight in the original implementation.

Maybe add a test for this (and the other field metadata APIs, if they're not covered?)

@Brar Brar force-pushed the ReplicationValueGetFieldName branch from 9430b7c to cefacb2 Compare June 28, 2024 16:33
@Brar Brar merged commit d36b2f5 into npgsql:main Jun 28, 2024
Brar added a commit that referenced this pull request Jun 29, 2024
@Brar
Add the field (column) name to ReplicationValue (#5719)
d3d8a85 
* Add the field (column) name to ReplicationValue and add test for field information accessor methods

Closes #5718

(cherry picked from commit d36b2f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider adding the field name to ReplicationValue
2 participants
@Brar @roji