fix(#5674): buffer over-read with ArrayNullabilityMode.PerInstance #5675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CanConvert` was not overridden for `PolymorphicArrayConverter<T>`, but 8 bytes but be read-ahead in order to populate `containsNulls` in `Read`/`ReadAsync`.
|
I'm not certain what the appropriate steps are, but this seems like the type of thing that should be patched for existing versions (I know for certain it affects Npgsql 8.0.2). Let me know if I need to take any action to backport the fix. |
|
@John-Paul-R thanks for finding and fixing this issue. I've slightly improved the requirements as they are only correct for reads but beyond that, LGTM! I will also backport this to 8.0.3. |
NinoFloris
approved these changes
Apr 21, 2024
NinoFloris
pushed a commit
that referenced
this pull request
Apr 21, 2024
|
Backported to 8.0.3 via 5fd00dd |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanConvertwas not overridden forPolymorphicArrayConverter<T>, but 8 bytes but be read-ahead in order to populatecontainsNullsinRead/ReadAsync.Resolves #5674