Skip to content

5638 fix ipv6 string NpsqlInet constructor #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

AlexanderVagner
Copy link
Contributor

Fixes #5638

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM but one minor suggestion.

@roji
Copy link
Member

roji commented Mar 22, 2024

@AlexanderVagner pushed a commit that redoes the tests as pure unit tests, as this is purely about NpgsqlInet code which doesn't involve PG in any way.

@AlexanderVagner
Copy link
Contributor Author

@AlexanderVagner pushed a commit that redoes the tests as pure unit tests, as this is purely about NpgsqlInet code which doesn't involve PG in any way.

Thanks! You are right, it's more clear

@roji roji merged commit 56ee2f0 into npgsql:main Mar 22, 2024
roji pushed a commit that referenced this pull request Mar 22, 2024
@roji
Copy link
Member

roji commented Mar 22, 2024

Backported to 8.0.3 via c6d4343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of IPv6 from string in NpgsqlInet constructor
2 participants