Improve binary import perf #5598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0c0c69 to
3b14e7b
Compare
roji
approved these changes
Mar 6, 2024
|
I'll backport it to 8.0.3 as it's also a simplification of the write logic. Additionally we have #5513 which I'd like to get feedback on in the 8.x timeframe. |
NinoFloris
added a commit
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit f8ad54c)
|
Backported to 8.0.3 via a61a446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significantly improves maintainability. Given we're now delegating all write methods to one, instead of three mostly identical methods.