Add DI methods accepting a service provider action #5572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
LGTM.
One unrelated thought while reviewing this, is that we have no overloads which don't require a connection string. It's already possible to configure things entirely via NpgsqlDataSourceBuilder, so it may make sense to allow users to do AddNpgsqlDataSource with only a NpgsqlDataSourceBuilder lambda (with/without IServiceProvider). On the other hand, yet more overloads :/
Could be part of the more general push towards a connstring-less experience...
| /// Defaults to <see cref="ServiceLifetime.Singleton" />. | ||
| /// </param> | ||
| /// <returns>The same service collection so that multiple calls can be chained.</returns> | ||
| [EditorBrowsable(EditorBrowsableState.Never), Obsolete("Defined for binary compatibility with 7.0")] |
There was a problem hiding this comment.
Yeah I heard it didn't pan out. They're going for a much more general mechanism now dotnet/csharplang#7706
MiBu
approved these changes
Mar 7, 2024
|
Backported to 8.0.3 via cb9d849 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4822