Tupled record array fix #5551
Merged
Tupled record array fix #5551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
reviewed
Jan 30, 2024
9d9a683 to
b5d93c3
Compare
vonzshik
approved these changes
Jan 31, 2024
|
Backported to 8.0.2 via 77bc742 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly synthesize array mappings over the concrete type of the tuple not - as previously - the stand-in
{Value}Tuple<object>type.Refactored to use the DynamicTypeInfoResolver infra. Its entire point is to make these kinds of resolvers easier to write (it just didn't exist at the time we wrote the tupled record resolver).
This issue wasn't noticed as we weren't testing the valuetuple and tuple array mappings correctly.
Fixes #5518