Bring UnsupportedTypeInfoResolver up-to-date with current mechanics #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d3ca13 to
1dd0795
Compare
|
Backported to 8.0.2 via 7691c95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the unsupported checks up-to-date with the work we did to support cross-cutting opt-ins for array/ranges/multiranges. Notably we are now flowing down whether any of those api gestures were called to decide whether to surface these
NotEnableddiagnostics.I've also removed checks that were needed when we did 'object or default' multipass resolving, so we would not trigger an exception on the first pass (we might remove the multi-pass mechanism entirely at a later date). The complete reliance on multi-pass resolutions was ameliorated by synthesizing an object mapping for default mappings instead; Fixing the startup time regression observed in the perf lab by allowing resolvers to lazily create their mappings.
And finally this also fixes an oversight where we wouldn't trigger any helpful exceptions on the array variant of datatype names checked in the unsupported resolver.
Fixes #5550 and should go into 8.0.2