Fix async nullable read creating an allocation #5555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49817ca to
dcbc1d3
Compare
vonzshik
approved these changes
Jan 31, 2024
NinoFloris
added a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit df80534)
|
Backported to 8.0.2 via 62701ba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing (T?)(object)(T)value apparently causes the jit to emit a box, even though it knows both concrete types due to specializiation.
Fix by making the method constrained to struct so we can concretely wrap the T instead of using the unboxing support for nullables.