Correctly handle resolver info in binary exporter #5546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6436979 to
bb2a6b3
Compare
NinoFloris
commented
Jan 24, 2024
| // Binary export has no type info so we only do caller-directed interpretation of data. | ||
| return info.Bind(new Field("?", info.PgTypeId!.Value, -1), DataFormat.Binary); | ||
| return info.Bind(new Field("?", | ||
| info.PgTypeId ?? ((PgResolverTypeInfo)info).GetDefaultResolution(null).PgTypeId, -1), DataFormat.Binary); |
There was a problem hiding this comment.
We need to do this GetDefaultResolution crap as we do not know what we should pick otherwise. (COPY being untyped)
roji
approved these changes
Jan 24, 2024
| @@ -150,7 +150,7 @@ internal bool TryBind(Field field, DataFormat format, out PgConverterInfo info) | |||
| return true; | |||
| case PgResolverTypeInfo resolverInfo: | |||
| var resolution = resolverInfo.GetResolution(field); | |||
| if (!HasCachedInfo(resolution.Converter) | |||
| if (HasCachedInfo(resolution.Converter) | |||
There was a problem hiding this comment.
Ha, the good old inversed logic bug...
There was a problem hiding this comment.
Yup, wasn't noticed as it was only a problem for reads over undecided type infos.
So never, except for binary export :')
|
Backported to 8.0.2 via 31941d1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5520