Decimal scale was lost when dealing with decimal zero #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xfischer Thanks for finding this edge case! I've pushed a small change to your branch, but overall LGTM. |
|
Thanks ! Works for me. Should I start the PR again ? |
|
@xfischer no need! It was late and CI was slow. It all looks good so I'll merge this in now. |
NinoFloris
approved these changes
Jan 31, 2024
|
Backported to 8.0.2 via 2d85369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ! I had an issue when dealing with decimal zero with scale defined (ie 0.00M).
Those fields were converted to plain 0M, loosing the scale.
I've added a "naive" fix to address this issue and a test showcasing the issue. I'm sorry to provide comparison with string representation, but I couldn't find a proper way to check if 0.00M is a zero with 2 decimal places also 0.
BTW I want to thank you for the great work here !