Skip to content

Fix memory leak while asynchronously disposing NpgsqlDataSource #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix memory leak while asynchronously disposing NpgsqlDataSource #5514

merged 2 commits into from
Jan 5, 2024

Conversation

vonzshik
Copy link
Contributor

@vonzshik vonzshik commented Jan 5, 2024

Fixes #5512

@vonzshik vonzshik marked this pull request as ready for review January 5, 2024 09:46
@vonzshik vonzshik requested a review from roji as a code owner January 5, 2024 09:46
roji
roji reviewed Jan 5, 2024
View reviewed changes
@vonzshik vonzshik enabled auto-merge (squash) January 5, 2024 11:43
@vonzshik vonzshik merged commit 0fde265 into main Jan 5, 2024
@vonzshik vonzshik deleted the 5512-data-source-dispose-async-memory-leak branch January 5, 2024 11:50
vonzshik added a commit that referenced this pull request Jan 5, 2024
@vonzshik
Fix memory leak while asynchronously disposing NpgsqlDataSource (#5514)
768c881 
Fixes #5512

(cherry picked from commit 0fde265)
@vonzshik
Copy link
Contributor Author

vonzshik commented Jan 5, 2024

Backported to 8.0.2 via 768c881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NpgsqlDataSource leaks because of undisposed MetricsReporter
2 participants
@vonzshik @roji