Simplify field reads #5480
Open
Simplify field reads #5480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
368cc98 to
c9212f3
Compare
c9212f3 to
a22a718
Compare
This was referenced Mar 17, 2024
Draft
5b91717 to
cf122e5
Compare
e447179 to
aab2833
Compare
aab2833 to
e950992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the stream handling into the Ado resolver.
Based on #5476
Any reviews should start from the last commit
Simplify by resolving Stream by default as a converterAfter this pack of changes (though that ideally includes #5471) we are able to fully inline everything on the hot path into GetFieldValueCore.
DPGO was even happy to make one huge 8000 bytes method (arm64) out of my local reproduction of the fortunes scenario, inlining even GetFieldValueCore itself.
Imprecise local benchmarking shows about a 3% improvement in fortunes RPS.