Skip to content

Consistently check disposed, closed and in result status #5471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2024
Merged

Consistently check disposed, closed and in result status #5471

merged 2 commits into from
Mar 25, 2024

Conversation

NinoFloris
Copy link
Member

Some checks were moved from private methods up to the public method instead

@NinoFloris NinoFloris added this to the 9.0.0 milestone Dec 3, 2023
NinoFloris
NinoFloris commented Dec 3, 2023
View reviewed changes
@NinoFloris NinoFloris force-pushed the improve-state-checks branch 4 times, most recently from 35b26ca to 90f9355 Compare December 3, 2023 20:19
@NinoFloris NinoFloris mentioned this pull request Dec 6, 2023
Open
@NinoFloris NinoFloris force-pushed the improve-state-checks branch from 90f9355 to 1a37adf Compare March 17, 2024 17:04
@NinoFloris NinoFloris closed this Mar 25, 2024
@NinoFloris NinoFloris reopened this Mar 25, 2024
@NinoFloris NinoFloris merged commit cda190b into main Mar 25, 2024
@NinoFloris NinoFloris deleted the improve-state-checks branch March 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji Awaiting requested review from roji roji is a code owner

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

Assignees

@NinoFloris NinoFloris

Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@NinoFloris