Pick the task constructor by using the right ValueTask type #5487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5484 We were instead putting a Task<T> as a *result* into the ValueTask before taking it out again...
a2cd83c to
25c9445
Compare
NinoFloris
added a commit
that referenced
this pull request
Dec 7, 2023
|
Backported to 8.0.2 via dbac459 |
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 20, 2023
) Fixes npgsql#5484 (cherry picked from commit dbac459) Signed-off-by: monjowe <jonas.westman@monitor.se>
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 21, 2023
) Fixes npgsql#5484 (cherry picked from commit dbac459) Signed-off-by: monjowe <jonas.westman@monitor.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5484
We were instead putting a Task as a result into the ValueTask before taking it out again...