Skip to content

Conversation

NinoFloris
Copy link
Member

Might finally put #5430 to bed...

We'll have to decide to take this one or take the straight forward algorithm (but larger change overall) in #5476 for 8.0.2.

This worked entirely by accident before due to us not resetting FieldSize after Commit
@NinoFloris NinoFloris force-pushed the fix-another-sequential-seek-exit-state branch from 3e08f38 to db362fa Compare December 7, 2023 15:59
Copy link
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's go with the simplest solution we have for backporting. If we ever encounter another issue which should have been fixed with #5476, then we'll think about backporting that pr.

@yunfandev
Copy link

yunfandev commented Jan 18, 2024

@NinoFloris @roji

Hi, I hope this message finds you well. I've been closely following this pull request and appreciate the work that has gone into it. Understanding that everyone is quite busy, I was wondering if there might be any updates on the timeline for a review or merge. Thank you for your dedication to maintaining this project! And whether the issue addressed in this pull request will be fixed in Npgsql version 8.0.2?

@NinoFloris NinoFloris merged commit dffa843 into main Jan 24, 2024
@NinoFloris NinoFloris deleted the fix-another-sequential-seek-exit-state branch January 24, 2024 21:46
NinoFloris added a commit that referenced this pull request Jan 31, 2024
Fixes #5430

(cherry picked from commit dffa843)

# Conflicts:
#	src/Npgsql/NpgsqlDataReader.cs
@NinoFloris
Copy link
Member Author

Backported to 8.0.2 via 85ed424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants