Default to invariant culture when using static snake case conversion #5448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nslator.ConvertToSnakeCase
|
@azygis I must be missing something. Why can't users of ConvertToSnakeCase not just pass it CultureInfo.InvariantCulture today? |
|
@NinoFloris they absolutely can. For the sake of consistency (ctor allows not passing it) and convenience (unnecessary noise in the calling code), I think it's good to have it optional on the static method as well. In OP I mention passing null as impossible, not other cultures. |
|
Makes sense. @vonzshik pointed out to me the xmldoc already mentions null should default to InvariantCulture. Let's merge it for 8.0.2 |
NinoFloris
approved these changes
Jan 31, 2024
|
Backported to 8.0.2 via 8822656 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Culture info was introduced with #5172. Unfortunately, it wasn't implemented completely correctly - the static conversion method is exposed, and to that you cannot pass null as you'd end up with
ArgumentNullExceptionfromchar.ToLower().This PR fixes that and defaults to
CultureInfo.InvariantCultureas well.