Reuse parameter index for all case permutations #5432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonzshik
reviewed
Nov 21, 2023
0b1231e to
c00d29c
Compare
vonzshik
approved these changes
Nov 21, 2023
NinoFloris
added a commit
that referenced
this pull request
Nov 21, 2023
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 20, 2023
Fixes npgsql#5428 (cherry picked from commit aebf620) Signed-off-by: monjowe <jonas.westman@monitor.se>
JonasWestman
pushed a commit
to monitor-erp/npgsql
that referenced
this pull request
Dec 21, 2023
Fixes npgsql#5428 (cherry picked from commit aebf620) Signed-off-by: monjowe <jonas.westman@monitor.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5428
Given we bind before we write, and reset all the bind info after writing we can't have multiple param indices pointing to the same parameter instance.
This is already guarded against for positional via the NpgsqlParameterCollection ownership check (can't add the same instance twice as it's already part of a collection). While for multiple same cased name references we already folded those to the same index.