cache: update MemoryCacheStore default limits #4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default values from Infinity to practical limits: - maxCount: 1024 entries (was Infinity) - maxSize: 100MB (was Infinity) - maxEntrySize: 5MB (was Infinity) Updated documentation and added tests to verify defaults. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
Replace ineffective test with meaningful tests that verify: - maxCount default (1024) prevents unlimited entries - maxEntrySize default (5MB) rejects large entries These tests actually validate the memory leak prevention behavior similar to the test.mjs example. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com>
metcoder95
reviewed
Jun 26, 2025
metcoder95
approved these changes
Jun 26, 2025
Merged
Uzlopak
pushed a commit
that referenced
this pull request
Jun 27, 2025
* cache: update MemoryCacheStore default limits Change default values from Infinity to practical limits: - maxCount: 1024 entries (was Infinity) - maxSize: 100MB (was Infinity) - maxEntrySize: 5MB (was Infinity) Updated documentation and added tests to verify defaults. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> * test: improve MemoryCacheStore default limits tests Replace ineffective test with meaningful tests that verify: - maxCount default (1024) prevents unlimited entries - maxEntrySize default (5MB) rejects large entries These tests actually validate the memory leak prevention behavior similar to the test.mjs example. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matteo Collina <hello@matteocollina.com> --------- Signed-off-by: Matteo Collina <hello@matteocollina.com> Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
Fixes #4208