Doc cors spec compliance #4202
Merged
Doc cors spec compliance #4202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
May 10, 2025
| ##### Garbage Collection | ||
| #### CORS | ||
|
|
||
| Unlike browsers, Undici does not implement CORS (Cross-Origin Resource Sharing) checks by default. This means: |
There was a problem hiding this comment.
Adding a reference to the relevant part of the fetch spec would be useful.
There was a problem hiding this comment.
Would a link to this section suffice? If so I can address in a separate PR.
https://fetch.spec.whatwg.org/#cors-check
KhafraDev
approved these changes
May 10, 2025
| ##### Garbage Collection | ||
| #### CORS | ||
|
|
||
| Unlike browsers, Undici does not implement CORS (Cross-Origin Resource Sharing) checks by default. This means: |
There was a problem hiding this comment.
Suggested change
| Unlike browsers, Undici does not implement CORS (Cross-Origin Resource Sharing) checks by default. This means: | |
| Unlike browsers, Undici does not implement CORS (Cross-Origin Resource Sharing) checks. This means: |
"by default" makes it sound like there is a way to enable CORS.
There was a problem hiding this comment.
Good point. Will address if a new PR is created for the suggestion above.
caitp
pushed a commit
to caitp/undici
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a section to the documentation detailing the default CORS behaviour mentioned in #4179.