cache: honour unqualified no-cache response directive #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndrsn
commented
Apr 23, 2025
added 2 commits
April 23, 2025 09:27
metcoder95
reviewed
Apr 23, 2025
metcoder95
approved these changes
Apr 23, 2025
pimterry
approved these changes
Apr 23, 2025
dhalbrook
pushed a commit
to dhalbrook/undici
that referenced
this pull request
Apr 24, 2025
* cache: honour unqualified no-cache response directive Closes nodejs#4173 * move test to interceptors/cache.js * lint * remove duplicate close() --------- Co-authored-by: alxndrsn <alxndrsn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4173
This relates to...
no-cacheresponse directive #4173Rationale
https://datatracker.ietf.org/doc/html/rfc9111#name-no-cache-2:
Changes
Add additional check of
no-cachedirective of cached response when deciding if it needs revalidation.Features
Na?
Bug Fixes
no-cacheresponse directive #4173Breaking Changes and Deprecations
Changes caching behaviour.
Status